[Wayland-bugs] [Bug 766341] Do not rely on memfd as it requires a fairly recent kernel

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766341

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327791|none                        |reviewed
             status|                            |

--- Comment #14 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 327791:

Other than that, looks fine.

::: gdk/wayland/gdkdisplay-wayland.c
@@ +1100,3 @@
+          random_byte == '/')
+        continue;
+

This looks a bit manual and wasteful to me. Instead of throwing away most of
the randomness and using only one byte at a time, I'd probably translate the
whole random int into hex digits in one go. No need to look out for / and \0
either then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160515/60478b8a/attachment.html>