[Wayland-bugs] [Bug 766341] Do not rely on memfd as it requires a fairly recent kernel

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766341

Ray Strode [halfline] <rstrode at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327992|accepted-commit_now         |needs-work
             status|                            |

--- Comment #27 from Ray Strode [halfline] <rstrode at redhat.com> ---
Review of attachment 327992:

::: gdk/wayland/gdkdisplay-wayland.c
@@ +1092,3 @@
+    {
+      g_critical (G_STRLOC ": creating shared memory file failed: %m");
+      return NULL;

still needs work, this shouldn't say NULL, but should say -1.

@@ -1090,3 @@
-  ret = syscall (__NR_memfd_create, "gdk-wayland", MFD_CLOEXEC);
-
-  if (ret < 0)

we ended up inadvertently losing error handling here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160516/76746cf1/attachment.html>