[Wayland-bugs] [Bug 766566] Wayland: gdk_screen_get_monitor_at_window() unreliable under Wayland

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766566

Emmanuele Bassi (:ebassi) <ebassi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328081|none                        |reviewed
             status|                            |

--- Comment #4 from Emmanuele Bassi (:ebassi) <ebassi at gmail.com> ---
Review of attachment 328081:

::: gdk/wayland/gdkdisplay-wayland.c
@@ +853,3 @@
+
+  output = gdk_wayland_window_get_wl_output (window);
+  struct wl_output *output;

Instead of nesting the for loop under the if, you can flip the condition check
and bail out early:

  if (output == NULL)
    return NULL;

  for (i = 0; ...
    {
      ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160517/f695996a/attachment.html>