[Wayland-bugs] [Bug 773274] [Wayland] Crash under gdk_wayland_window_attach_image()

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773274

Ray Strode [halfline] <rstrode at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338945|reviewed                    |accepted-commit_now
             status|                            |

--- Comment #22 from Ray Strode [halfline] <rstrode at redhat.com> ---
Review of attachment 338945:

You write "doesn't check if the drop_cairo_surfaces" but I think you mean the
"staging_cairo_surface".  But also, I wish the commit message went into the
specific problem a little bit. Maybe something like
"gdk_wayland_window_attach_image is normally called from gdk_window_end_paint
to notify the compositor of newly staged drawing.  If any of the drawing code
inadvertently dispatches the wayland event loop (for instance with a gdk_flush
call), then it's possible that by the time gdk_window_end_paint is called, the
staged drawing is already destroyed.  This commit bypasses the attach_image
call in scenarios where the staged drawing is prematurely dropped"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20161102/87248987/attachment.html>