[Wayland-bugs] [Bug 773210] [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773210

Rui Matos <tiagomatos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338086|none                        |reviewed
             status|                            |

--- Comment #9 from Rui Matos <tiagomatos at gmail.com> ---
Review of attachment 338086:

Honestly, I'd prefer to just delete the code in meta_window_show() that calls
meta_display_focus_the_no_focus_window() instead of using a weakly defined
window type for these popups.

I just can't think of any case where it makes sense for a new window to cause
us to globally unset focus. Anyone can?

::: src/core/window.c
@@ +7807,3 @@
    */
+  if (window->override_redirect ||
+      window->type == META_WINDOW_OVERRIDE_OTHER)

This should in any case be a separate patch since it's a different issue, and
check for any of the OR window types, not just this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20161021/d96456ec/attachment.html>