[Wayland-bugs] [Bug 770906] Wayland: Unmapping a toplevel from a menu/popup can lead to a protocol error

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770906

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335336|none                        |accepted-commit_now
             status|                            |

--- Comment #8 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 335336:

Looks good; just only one nit below.

::: gdk/wayland/gdkwindow-wayland.c
@@ +2349,3 @@
+         }
+       current_popups = g_list_next (current_popups);
+    }

Just a nit: this is an iterator of a GList. Those usually look like
GList *l;

for (l = ... ; l; l = l->next)
  ...

so it'd be clearer we just used the same method here as elsewhere. Also no need
to pass the 'current_popups' as a parameter really, as that function will never
be called with anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160912/c2a5ce21/attachment.html>