[Wayland-bugs] [Bug 781285] New: Key repeat cancel under Wayland should depend on which key is repeating

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781285

            Bug ID: 781285
           Summary: Key repeat cancel under Wayland should depend on which
                    key is repeating
    Classification: Platform
           Product: gtk+
           Version: 3.22.x
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Backend: Wayland
          Assignee: gtk-bugs at gtk.org
          Reporter: dant at pnym.net
        QA Contact: gtk-bugs at gtk.org
                CC: rob at robster.org.uk, wayland-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 349836
  --> https://bugzilla.gnome.org/attachment.cgi?id=349836&action=edit
[PATCH] wayland: selectively cancel key repeat on key release

Under Wayland, when multiple keys are pressed and the user releases a key, key
repeat should continue unless the key released is the one currently repeating.

In the case of:

- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key2 repeats
- key2 release

The behavior should be to cancel keyboard repeat, though key1 is still held
down. This is consistent with prior X11/XWayland behavior.

The following also must work:

- key1 press
- key2 press
- key2 release
- key2 press
- key1 release
- key2 should continue to repeat

The fix for bug #778019 should continue to work:

- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key1 release
- key2 should repeat

The choice to change the counter nkeys to the flag repeat_active helps to solve
the second test case.

Attached is a proposed patch to fix this behavior.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170413/32d2921a/attachment.html>