[Wayland-bugs] [Bug 786455] [PATCH] gdk/wayland: allow focusing without a specific timestamp

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786455

--- Comment #4 from Carlos Garnacho <carlosg at gnome.org> ---
(In reply to Xiang Fan from comment #2)
> (In reply to Matthias Clasen from comment #1)
> > this patch doesn't really 'handle' it in any way though, and just passes it
> > through, ignoring the comment that it removes
> 
> It's handled in mutter:
> https://git.gnome.org/browse/mutter/tree/src/core/window.c#n3395
> 
> Also please look at this commit:
> [window: Treat CurrentTime as legal timestamp in activation]
> https://git.gnome.org/browse/mutter/commit/
> ?id=5defe574d74eace55bfe9e7e79ffaaa40f50372f
> 
> So IMHO it's safe to consider GDK_CURRENT_TIME valid and just pass it
> through.

I'd like to point out that mutter figuring out a decent timestamp for the
request does not mean that passing GDK_CURRENT_TIME is correct, nor desirable
according to the semantics of a "present" request.

What would happen here is that the request gets the timestamp at the time
Mutter is processing the request, not the time of the input event that
triggered the window to be shown. The latter is useful to Mutter to determine
whether there was further activity after the present request, the former is a
randomly recent timestamp that will beat anything else, and pretty much defeats
the purpose of a timestamp in the "present" request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170823/07afee97/attachment.html>