[Wayland-bugs] [Bug 778019] Key repeat under wayland behaves differently, making keyboard navigation e.g. in vim annoyingly unreliable

gtk+ (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 27 09:26:29 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=778019

--- Comment #4 from Olivier Fourdan <ofourdan at redhat.com> ---
(In reply to Carlos Garnacho from comment #3)
> Review of attachment 344764 [details] [review]:
> 
> Looks good! just a minor comment, feel free to push after fixing.
> 
> ::: gdk/wayland/gdkdevice-wayland.c
> @@ +2154,1 @@
>    seat->repeat_count++;
> 
> This should probably only happen if state!=0, not that it matters much in
> practice, since we just ever check for repeat_count == 1.

Err nope, if we do repeat_count++ only on key press (i.e. state != 0) we don't
get the expected behavior, the repeat pauses twice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170227/3a348e84/attachment.html>


More information about the wayland-bugs mailing list