[Wayland-bugs] [Bug 101574] Palm detection with TrackPoint buttons

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 3 06:23:38 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101574

--- Comment #10 from Peter Hutterer <peter.hutterer at who-t.net> ---
Comment on attachment 132395
  --> https://bugs.freedesktop.org/attachment.cgi?id=132395
patch to add tp_palm_in_edge helper function

Review of attachment 132395:
-----------------------------------------------------------------

just one comment on this one, I've changed a few things, will attach the new
patch in a tick

::: src/evdev-mt-touchpad.c
@@ +562,5 @@
>  {
>  	if (t->state != TOUCH_BEGIN)
>  		return false;
>  
> +	if (tp_palm_in_edge(tp, t))

This bit looks definitely buggy: the previous check returned false if it was
*not* in the palm edge area, this one returns false if it's inside the palm
edge area now

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170703/ac2dc327/attachment.html>


More information about the wayland-bugs mailing list