[Wayland-bugs] [Bug 777333] In a GNOME Wayland session, gnome-terminal windows cannot be moved around with a wacom pen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777333

Carlos Garnacho <carlosg at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354345|none                        |reviewed
             status|                            |

--- Comment #9 from Carlos Garnacho <carlosg at gnome.org> ---
Review of attachment 354345:

Makes sense, and turns out it's sufficient for window dragging. We still do
need something like MetaWaylandPointerGrabInterface to cater for dnd and
xdg_popup, but probably can be handled separately.

The patch itself looks good! Just a minor comment.

::: src/wayland/meta-wayland-tablet-tool.c
@@ +886,3 @@
+      tool->grab_button = event->button.button;
+      tool->grab_time = clutter_event_get_time (event);
+      tool->grab_serial = wl_display_get_serial
(tool->seat->seat->wl_display);

grab_serial seems unused. You compare with both down_serial and button_serial
on can_grab_surface() which seems right.

Same for grab_button and grab_time, really...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170705/7288b7af/attachment.html>