[Wayland-bugs] [Bug 100040] Skype crashes XWayland which kills GNOME session

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100040

--- Comment #8 from Michel Dänzer <michel at daenzer.net> ---
(In reply to Mark B from comment #7)
> When I look at the new patch I see that the clientGone test has been removed
> from sync_callback() compared to the original patch. That's good to prove
> the new changes still address the issue but personally I would be more at
> ease if that clientGone check was still included for the final release
> patch. It's a one-liner check, costs nothing, and assures ultimate
> protection.

Not really. The check could only make any difference if
xwl_auth_state_client_callback fails to cancel the sync callback before the
client is destroyed. In which case, the memory pointed to by state->client may
already have been freed or reclaimed for a different client, so the
client->clientGone value cannot be relied on anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170309/e8146e39/attachment.html>