[Wayland-bugs] [Bug 775099] Shell search provider doesn't work with Wayland

[gnome-shell (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775099

Florian Müllner <florian.muellner at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350958|none                        |reviewed
             status|                            |

--- Comment #14 from Florian Müllner <florian.muellner at gmail.com> ---
Review of attachment 350958:

The commit message is poorly worded - "respect foo property" sounds like there
was a well-established field that we failed to support, rather than something
newly made-up. And of course a search provider keyfile is not a .desktop file
...

::: js/ui/search.js
@@ +184,2 @@
     _activateResult: function(result, id) {
         this.provider.activateResult(id, this._terms);

Does this make sense, or should we assume that if copyResult is set, then the
app uses the activate-copies pattern?

@@ +185,3 @@
         this.provider.activateResult(id, this._terms);
+        if (this.provider.copyResult)
+            this._clipboard.set_text(St.ClipboardType.CLIPBOARD, id);

Of course this doesn't copy the result, but its ID. While I don't know about
any other search provider that uses the activate-copies pattern, this looks
needlessly restrictive.

Maybe something like:

  activateResult: function(id, terms) {
      if (this.copyResult)
          this.proxy.GetResultClipboardTextRemote(id, (text, error) => {
              this._clipboard.set_text(St.ClipboardType.CLIPBOARD, text);
          });
      else
          this.proxy.ActivateResultRemote(id, terms,
global.get_current_time());
  },

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170509/25e7ae02/attachment.html>