[Wayland-bugs] [Bug 745289] wayland: do not use g_error() on connection errors

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745289

Debarshi Ray <rishi.is at lostca.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298098|none                        |committed
             status|                            |

--- Comment #3 from Debarshi Ray <rishi.is at lostca.se> ---
Review of attachment 298098:

Looks similar to:
https://bugzilla.redhat.com/show_bug.cgi?id=1366897
https://bugzilla.gnome.org/show_bug.cgi?id=783047

(updating the patch's status to reflect reality)

::: gdk/wayland/gdkeventsource.c
@@ +164,3 @@
+        {
+          g_warning ("Error %d (%s) dispatching to Wayland display.",
+                     errno, g_strerror (errno));

Maybe we should use g_message instead?

See https://bugzilla.redhat.com/show_bug.cgi?id=1366897#c43 for a rationale.
The X11 backend (gdk_x_io_error) also uses g_message these days.

@@ +165,3 @@
+          g_warning ("Error %d (%s) dispatching to Wayland display.",
+                     errno, g_strerror (errno));
+          exit (1);

Also, maybe, _exit instead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170524/8e57b5e6/attachment-0001.html>