[Wayland-bugs] [Bug 774065] Entry completion drop-down is misplaced on external monitor when on Wayland

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774065

--- Comment #11 from Guillaume Ayoub <xovni at wanadoo.fr> ---
(In reply to Jonas Ådahl from comment #10)
> Review of attachment 366086 [details] [review]:
> 
> Thanks a lot for this!

I've done my best, but it looks like an ugly patch, not a real solution. I've
tried with Xorg and it's broken :/.

> Here is some review:
> 
> Have this been tested on both input grabbing and not input grabbing entry
> completion? Do we have test cases for both kinds?

No, I don't even know what you're talking about…

> Another question is how this deals with entry completion windows being
> moved, as move_to_rect() can't deal with moving visible windows right now.
> Do we have test cases for that? Do we even support that?

It's possible to move the input window when the dropdown window is open, for
example by maximizing/minimizing epiphany using keyboard shortcuts. With the
patch, the dropdown window doesn't move with the input window. I don't know how
it was before the patch.

> Lastly, for the future, please attach patches generated from "git
> format-patch" with commit message and author information.

I'll try to remember that!

> ::: gtk/gtkentrycompletion.c
> @@ +609,3 @@
>    priv->popup_window = gtk_window_new (GTK_WINDOW_POPUP);
> +  /* Using subsurface prevents gdk_window_move_to_rect from working */
> +  /* gtk_window_set_use_subsurface (GTK_WINDOW (priv->popup_window), TRUE);
> */
> 
> We should just remove this, not comment it out.

Of course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180201/f2492d10/attachment.html>