[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

Bastien Nocera <bugzilla at hadess.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368197|accepted-commit_now         |needs-work
             status|                            |

--- Comment #5 from Bastien Nocera <bugzilla at hadess.net> ---
Review of attachment 368197:

I don't think this is a good enough interface for GTK+ to use, but best discuss
it in a location where it will be implemented (in gnome-settings-daemon)

::: gdk/wayland/gdkscreen-wayland.c
@@ +919,3 @@
+  if (proxy == NULL)
+    {
+      if (error != NULL)

This will warn for every GTK+ app running under a non-GNOME Wayland server.

@@ +946,3 @@
+        screen_wayland->fc_settings.timestamp = (guint)timestamp;
+      else if (timestamp > G_MAXUINT)
+        g_warning ("Could not handle fontconfig init: timestamp too long");

too long?

@@ +975,3 @@
+                            G_DBUS_PROXY_FLAGS_NONE,
+                            NULL,
+                            GSD_DBUS_FONTCONFIG_NAME,

This is highly GNOME specific.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180222/cd269b18/attachment.html>