[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

Martin Blanchard <tchaik at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369118|needs-work                  |none
             status|                            |
 Attachment #369118|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Blanchard <tchaik at gmx.com> ---
Created attachment 369162
  --> https://bugzilla.gnome.org/attachment.cgi?id=369162&action=edit
'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland

Fifth version: Keep dbus connection's cancellable alive all along
GdkWaylandScreen's lifetime.

(In reply to Bastien Nocera from comment #10)
> @@ +929,3 @@
> +  g_clear_object (&screen_wayland->dbus_cancellable);
> 
> No, don't do this, keep it around.
> Instead, you'll want to cancel it it in dispose().

Ok.

> @@ +955,3 @@
> +    }
> +
> +  g_variant_unref (value);
> 
> g_variant_unref() doesn't like being passed NULL.

Ouch...

> @@ +963,3 @@
> +    {
> +      modules = g_variant_get_string (value, &length);
> +      screen_wayland->dbus_settings.modules = g_strndup (modules, length);
> 
> You're leaking the old value of dbus_settings.modules.
> 
> Seeing as the string will be nul-terminated, free the old string, and use
> g_variant_dup_string() to assign the new value.

Well, I'm expecting this to be called only once, at object's initialisation
time. Are there any case where this would be called again for the same
GdkWaylandScreen instance? Anyway, string gets freed now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180301/e80ef845/attachment.html>