[PATCH 3/6] desktop-shell: split protocol part from shell_surface specific functions

[Pekka Paalanen]

On Mon, 16 Apr 2012 17:31:42 +0300
Tiago Vignatti <tiago.vignatti at intel.com> wrote:

> DE operations like toplevel, transiant, fullscreen, maximized, popup and the
> shell_surface constructor are the ones expected to be used in the global scope
> for Weston submodules like xserver-launcher and other shells.
> 
> This commit split such procedures into a part that handles the protocol
> request and a part that creates the shell surface and deals with its
> operations. There's no functional changes in this commit.
> 
> Signed-off-by: Tiago Vignatti <tiago.vignatti at intel.com>
> ---
>  src/compositor.h |    1 +
>  src/shell.c      |  208 ++++++++++++++++++++++++++++++++++++------------------
>  2 files changed, 140 insertions(+), 69 deletions(-)
...
>  static void
> -shell_surface_set_transient(struct wl_client *client,
> -			    struct wl_resource *resource,
> -			    struct wl_resource *parent_resource,
> -			    int x, int y, uint32_t flags)
> +set_transiant(struct shell_surface *shsurf, struct shell_surface *pshsurf,
> +	      int x, int y, uint32_t flags)

Spelling: should be "transient".

On a quick look seems fine otherwise.


Thanks,
pq