[PATCH 3/6] desktop-shell: split protocol part from shell_surface specific functions

[Tiago Vignatti]

On 04/17/2012 08:31 AM, Juan Zhao wrote:
> On 04/16/2012 10:31 PM, Tiago Vignatti wrote:
>> static void
>> +shell_surface_set_maximized(struct wl_client *client,
>> + struct wl_resource *resource,
>> + struct wl_resource *output_resource )
>> +{
>> + struct shell_surface *shsurf = resource->data;
>> + struct weston_output *output;
>> +
>> + /* get the default output, if the client set it as NULL
>> + check whether the ouput is available */
> The comments should be moved to set_maximized.
> Others related to maximized looks OK for me. :)

yes.

Another issue was that struct weston_output pointer needed to be 
initialize as NULL for both set_maximized and set_fullscreen work 
correctly. I fixed locally these, thank you!

>> + if (output_resource)
>> + output = output_resource->data;
>> +
>> + set_maximized(shsurf, output);
>> +}


              Tiago