[PULL wayland] fd leak checks and a socket fallback

[Kristian Høgsberg]

Nice, that's all very clever :)  I merged it as is, but I was
wondering why you set errno to 0 in wl_os_socket_cloexec?  If socket
returns -1, will set errno, and if it doesn't, you don't need to look
at errno.  It's required for readdir and strtol, but shouldn't be
necessary for socket.

Kristian

On Fri, Apr 20, 2012 at 9:46 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Hi Kristian,
>
> finally I am getting the test framework up for my OS wrappers. I added
> automatic fd leak checks, and helpers for checking fd leaks through
> exec(). They have their sanity tests.
>
> The other feature in this series is the fallback for socket() and
> SOCK_CLOEXEC flag, which is not supported in Bionic. It comes with
> tests for both normal use and a forced fallback hack.
>
> If this series looks acceptable, I can clean up the rest of my OS
> wrappers and write tests for them.
>
> I haven't tried the tests on arm yet.
>
> http://cgit.collabora.com/git/user/pq/wayland.git/log/?h=for-krh
>
>
> The following changes since commit 2896b6a22040dab70655bc271025f99ba92e6bb1:
>
>  protocol: Add ping event and corresponding pong request (2012-04-19 12:48:55 -0400)
>
> are available in the git repository at:
>  git://git.collabora.co.uk/git/user/pq/wayland.git for-krh
>
> Pekka Paalanen (5):
>      tests: detect fd leaks
>      tests: plug fd leaks in free_source_with_data
>      tests: support testing fd inheritance over exec
>      os: wrap socket(SOCK_CLOEXEC) calls
>      tests: add .gitignore
>
>  src/Makefile.am              |    2 +
>  src/wayland-client.c         |    3 +-
>  src/wayland-os.c             |   69 +++++++++++++++++++++++++++++
>  src/wayland-os.h             |   29 ++++++++++++
>  src/wayland-server.c         |    3 +-
>  tests/.gitignore             |   10 ++++
>  tests/Makefile.am            |   26 ++++++++---
>  tests/event-loop-test.c      |    5 ++
>  tests/exec-fd-leak-checker.c |   75 +++++++++++++++++++++++++++++++
>  tests/os-wrappers-test.c     |  100 ++++++++++++++++++++++++++++++++++++++++++
>  tests/sanity-test.c          |   30 +++++++++++++
>  tests/test-helpers.c         |   64 +++++++++++++++++++++++++++
>  tests/test-runner.c          |    4 ++
>  tests/test-runner.h          |    6 +++
>  14 files changed, 418 insertions(+), 8 deletions(-)
>  create mode 100644 src/wayland-os.c
>  create mode 100644 src/wayland-os.h
>  create mode 100644 tests/.gitignore
>  create mode 100644 tests/exec-fd-leak-checker.c
>  create mode 100644 tests/os-wrappers-test.c
>  create mode 100644 tests/test-helpers.c
>
> Thanks,
> pq