[PATCH] shell: Remove confusing case fall-through
Rob Bradford
robert.bradford at intel.com
Thu Dec 6 04:07:48 PST 2012
From: Rob Bradford <rob at linux.intel.com>
This avoids calling weston_surface_set_position twice on the same surface. The
second call has no effect in many cases because sx and sy
are usually zero on this path.
This change now means that any sx/sy values passed into ::attach will be
ignored on the first attach for popup surfaces. This similar to the behaviour
for other surface types.
---
src/shell.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shell.c b/src/shell.c
index 89d7627..755c87e 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -2921,6 +2921,7 @@ map(struct desktop_shell *shell, struct weston_surface *surface,
break;
case SHELL_SURFACE_POPUP:
shell_map_popup(shsurf);
+ break;
case SHELL_SURFACE_NONE:
weston_surface_set_position(surface,
surface->geometry.x + sx,
--
1.7.11.7
More information about the wayland-devel
mailing list