[PATCH] shell: Remove confusing case fall-through

[Kristian Høgsberg]

On Thu, Dec 06, 2012 at 12:07:48PM +0000, Rob Bradford wrote:
> From: Rob Bradford <rob at linux.intel.com>
> 
> This avoids calling weston_surface_set_position twice on the same surface. The
> second call has no effect in many cases because sx and sy
> are usually zero on this path.
> 
> This change now means that any sx/sy values passed into ::attach will be
> ignored on the first attach for popup surfaces. This similar to the behaviour
> for other surface types.

Thanks, applied.
Kristian

> ---
>  src/shell.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/shell.c b/src/shell.c
> index 89d7627..755c87e 100644
> --- a/src/shell.c
> +++ b/src/shell.c
> @@ -2921,6 +2921,7 @@ map(struct desktop_shell *shell, struct weston_surface *surface,
>  		break;
>  	case SHELL_SURFACE_POPUP:
>  		shell_map_popup(shsurf);
> +		break;
>  	case SHELL_SURFACE_NONE:
>  		weston_surface_set_position(surface,
>  					    surface->geometry.x + sx,
> -- 
> 1.7.11.7
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel