[PATCH v2 weston 0/7] Server side wl_buffer.release

[Kristian Høgsberg]

On Tue, Dec 04, 2012 at 03:58:09PM +0200, Pekka Paalanen wrote:
> Hi Kristian,
> 
> this is the rebased and modifed version of the server side
> wl_buffer.release series.
> 
> Changes since v1:
> - rebased
> - added struct weston_buffer_reference to consolidate
> the destroy handler functions
> - shm flush on destroy is now a separate patch instead of in
> the gl patch
> - compositor-drm patch is squashed
> - clients: destroy wl_registry on exit has been left to be
> sent on its own
> - preserve and comment on gs->pitch initialisation, I missed
> it the last time

I applied the entire series.  I'm still not a fan of es->keep_buffer,
I'd rather we just unconditionally unref'ed the buffer (if
buffer_ref.buffer is not already NULL) in the accumulate_damage loop.
If a backend or renderer needs the buffer they've had the chance to
take a ref at this point.

Kristian

> Pekka Paalanen (7):
>   compositor: do not release if re-attaching buffer
>   compositor: do not flush shm buffer on destroy
>   compositor: introduce weston_buffer_reference
>   gl: take, hold, and release a buffer reference
>   compositor: add early wl_buffer.release
>   compositor: move pitch into renderer private
>   compositor: move texture_damage into renderer private
> 
>  src/compositor-drm.c |   66 +++++++++++++++-----------------
>  src/compositor-rpi.c |   11 ++++-
>  src/compositor.c     |  102 +++++++++++++++++++++++++++++--------------------
>  src/compositor.h     |   15 +++++--
>  src/gl-renderer.c    |   58 ++++++++++++++++++++--------
>  src/shell.c          |    2 +-
>  src/tablet-shell.c   |    4 +-
>  7 files changed, 154 insertions(+), 104 deletions(-)
> 
> -- 
> 1.7.8.6
>