xwm-client patches, version 2

[Scott Moreau]

On Wed, Dec 19, 2012 at 12:32 PM, Tiago Vignatti
<tiago.vignatti at intel.com>wrote:

> Hi. Quite many changes on version 2, the most noticeable being:
>
>   - set_xwayland -> set_transient_xwayland
>   - the new set_transient_xwayland type is not exposed to clients,
> therefore
>     no core protocol changes are needed anymore.
>   - added a documentation for weston_shell_interface (compositor.h)
>   - three interfaces now for the new XWayland protocol (xserver, wm and
>     wm_xwin)
>   - wm_xwin is easier to look up for window objects, hence hash table is
> not
>     implemented anymore on xwayland server side.
>
> I'd love to hear you guys testing the work now:
>   http://cgit.freedesktop.org/~vignatti/weston/log/?h=xwm-client
>   http://cgit.freedesktop.org/~vignatti/xserver/log/?h=xwm-client
>
>
> Merry Xmas and Happy new year all!
>
>     Tiago
>
> weston:
>   xwayland: Split header file in WM specific and XWayland internals
>   xwm: Disable opaque_rect settings
>   xwayland: Drop selection support
>   xwm: Remove support for transient windows
>   xwm: Get rid of compositor loop handlers
>   xwm: Change weston_log by fprintf
>   xwayland: Move hash implementation to shared
>   xwayland: Move window-manager files to client directory
>   Introduce new XWayland protocol and implementation
>   clients: xwm: Remove all references for weston
>   clients: xwm: Fix frame repaint
>   shell: Add transient XWayland shell surfaces
>   xwayland: Fix window positioning
>   xwayland: Fix opaque and input region settings
>   xwayland: Move selection to client side
>   xwayland: Proxy selection for copy-paste
>
>  clients/Makefile.am           |   17 +-
>  clients/xwm-selection.c       |  651 +++++++++++++++
>  clients/xwm.c                 | 1646
> ++++++++++++++++++++++++++++++++++++++
>  clients/xwm.h                 |  137 ++++
>  configure.ac                  |    2 +-
>  protocol/xserver.xml          |  204 ++++-
>  shared/Makefile.am            |    4 +-
>  shared/xwayland-hash.c        |  307 +++++++
>  shared/xwayland-hash.h        |   49 ++
>  src/compositor.c              |    1 +
>  src/compositor.h              |   36 +-
>  src/shell.c                   |   37 +-
>  src/xwayland/Makefile.am      |    9 +-
>  src/xwayland/hash.c           |  307 -------
>  src/xwayland/hash.h           |   49 --
>  src/xwayland/launcher.c       |   75 +-
>  src/xwayland/selection.c      |  703 ----------------
>  src/xwayland/window-manager.c | 1773
> ++++++-----------------------------------
>  src/xwayland/xwayland.h       |  114 +--
>  19 files changed, 3390 insertions(+), 2731 deletions(-)
>  create mode 100644 clients/xwm-selection.c
>  create mode 100644 clients/xwm.c
>  create mode 100644 clients/xwm.h
>  create mode 100644 shared/xwayland-hash.c
>  create mode 100644 shared/xwayland-hash.h
>  delete mode 100644 src/xwayland/hash.c
>  delete mode 100644 src/xwayland/hash.h
>  delete mode 100644 src/xwayland/selection.c
>
> xserver:
>   xwayland: Cache globals to avoid multiple registry objects
>   xwayland: Track new protocol for xwm split
>   xwayland: Attach and configure window only when asked by Wayland
>   xwayland: Track new protocol for xwm client side selection
>
>  hw/xfree86/xwayland/xserver.xml        |  204
> +++++++++++++++++++++++++++++++-
>  hw/xfree86/xwayland/xwayland-drm.c     |   35 ++----
>  hw/xfree86/xwayland/xwayland-input.c   |   50 ++------
>  hw/xfree86/xwayland/xwayland-output.c  |   38 +++---
>  hw/xfree86/xwayland/xwayland-private.h |   24 +++-
>  hw/xfree86/xwayland/xwayland-window.c  |    7 +-
>  hw/xfree86/xwayland/xwayland.c         |  111 ++++++++++++++++-
>  7 files changed, 365 insertions(+), 104 deletions(-)
>
> --
> 1.7.9.5
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>

Hi Tiago,

I decided to give this series a test run. The patches apply with a few
whitespace errors. As far as I can tell, xwayland clients work about the
same as without these patch sets. The worst thing I noticed was an
occasional decoration flicker when grabbing the titlebar. So thanks for
tackling this, you can have my Tested By here.


Thanks,

Scott
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20121219/7e19c70a/attachment.html>