[PATCH 1/2] New logging functionality

[Pekka Paalanen]

On Fri,  3 Feb 2012 00:16:00 +0200
ustun.ergenoglu at gmail.com wrote:

> From: Ustun Ergenoglu <ego at ustun.fi>
> 
> Added logging fuctions that print out to a logfile and stderr. Logging levels
> can be specified.
> 
> Signed-off-by: Ustun Ergenoglu <ego at ustun.fi>
> ---
>  src/Makefile.am   |    6 ++-
>  src/wayland-log.c |  131 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/wayland-log.h |   67 +++++++++++++++++++++++++++
>  3 files changed, 202 insertions(+), 2 deletions(-)
>  create mode 100644 src/wayland-log.c
>  create mode 100644 src/wayland-log.h
...
> diff --git a/src/wayland-log.c b/src/wayland-log.c
> new file mode 100644
> index 0000000..eb7528d
> --- /dev/null
> +++ b/src/wayland-log.c
...
> +WL_EXPORT void
> +wl_log(wl_log_level level, const char *format, ...)
> +{
> +	va_list args;
> +	va_start(args, format);
> +
> +	wl_log_va(level, format, args);
> +}

The above is missing a va_end().

Please, do not resend for only this one comment. Let us see what others
think first.


Thanks,
pq