[PATCH 0/2] Logging functions

Tiago Vignatti tiago.vignatti at linux.intel.com
Wed Feb 8 03:58:29 PST 2012

Hi Ustun! Sorry for delaying with an answer; comments are below.

On 02/03/2012 12:15 AM, ustun.ergenoglu at gmail.com wrote:
> From: Ustun Ergenoglu<ego at ustun.fi>
> Added new functions for logging and replaced the fprintf calls with the new
> wl_log calls.
> Ustun Ergenoglu (2):
>    New logging functionality
>    Replaced fprintf calls with the new wl_log function.

First, thanks for taking over this work. Much appreciated!

The idea in Wayland is to implement the log facility on Weston 
compositor side, which has a total of 190 fprintfs currently. For 
libwayland, as Kristian pointed before [0], we have to make it resilient 
and handle in case of errors instead just spit it to stderr. At the 
moment libwayland-* has 42 fprintfs, which is not much (including 
debugging, that we won't touch).

Anyways, in your patches I've seen that you didn't initialized the log 
facility (wl_log_init); not sure also whether we want wl_log_va in the 
API; and last, I'd remove the WL_LOG_UNKNOWN level, with the intent to 
force the developer think a bit more whenever he/she is coding and 
minimize the output.


[0] http://lists.fredesktop.org/archives/wayland-devel/2011-July/001233.html

More information about the wayland-devel mailing list