[PATCH 1/2] Don't send modifier events to toytoolkit clients.

[Pekka Paalanen]

On Sat,  3 Mar 2012 08:48:29 -0700
Scott Moreau <oreaus at gmail.com> wrote:

> Clients shouldn't attempt to track modifier state independently
> since it's already tracked in the modifier mask.

Hi Scott,

to me the commit message seems wrong compared to the change. When
you talk about sending and clients, and do not prefix the title
with window, I assume you are patching the server to not
send events to clients.

If I understood right, this patch would be better described as

	window: ignore modifier key events

	Toytoolkit apps should not even try to track modifier
	state, it is already tracked in the modifier mask.

Am I missing something?


Thanks,
pq

> ---
>  clients/window.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/clients/window.c b/clients/window.c
> index e917ce6..538571e 100644
> --- a/clients/window.c
> +++ b/clients/window.c
> @@ -1581,7 +1581,7 @@ input_handle_key(void *data, struct
> wl_input_device *input_device, if (state)
>  			window_set_maximized(window,
>  					     window->type !=
> TYPE_MAXIMIZED);
> -	} else if (window->key_handler) {
> +	} else if (window->key_handler
> && !d->xkb->map->modmap[code]) { (*window->key_handler)(window,
> input, time, key, sym, state, window->user_data);
>  	}
> -- 
> 1.7.4.1


-- 
Pekka Paalanen
http://www.iki.fi/pq/