[PATCH 1/2] Don't send modifier events to toytoolkit clients.

Scott Moreau oreaus at gmail.com
Sun Mar 4 01:01:25 PST 2012


>
> Hi Scott,
>
> to me the commit message seems wrong compared to the change. When
> you talk about sending and clients, and do not prefix the title
> with window, I assume you are patching the server to not
> send events to clients.
>
> If I understood right, this patch would be better described as
>
>        window: ignore modifier key events
>
>        Toytoolkit apps should not even try to track modifier
>        state, it is already tracked in the modifier mask.
>
> Am I missing something?
>
>
> Thanks,
> pq
>

Hi, thanks for your comments. I think perhaps this patch might not be the
right way
to do what it's intended to, which is avoid clients receiving mismatched
pairs of
modifier events when a grab is used. e.g. if a client receives a <modifier>
down
event and subsequently a grab is initiated, the client never gets the
<modifier> up
event when the grab is complete.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120304/dbc530f3/attachment.html>


More information about the wayland-devel mailing list