[PATCH] weston: Don't ask for EGL depth buffer if not needed

Pekka Paalanen ppaalanen at gmail.com
Thu Mar 22 01:43:36 PDT 2012

On Wed, 21 Mar 2012 14:41:52 -0700
Bill Spitzak <spitzak at gmail.com> wrote:

> Also, strangely enough, there actually *is* a depth buffer on the 
> resulting window, because z compositing works.

What is the z compositing you refer to? In which program?
Weston certainly has nothing that depends on a depth buffer.

> I would like to try a simple fix, with a comment in the code to say it 
> is to work around a nouveau bug. This is to ask for the depth buffer, 
> but if that fails to try again without it. Eventually this can be 
> removed when they fix the driver.

The failure is an assert, which kills the program later. You can't
really test for it. Oh, if you meant a user is supposed to find the
comment and manually edit the code and recompile, that's too

Like krh said, if we don't need a depth buffer, the right thing to do
is to not require one. As happy coincidence, it also works around a
Nouveau bug.

> PS: I have not heard anything about my changes to wayland (there are 5 
> patches). One of them fixed a major bug for me. I believe my EAGAIN 
> changes are a mistake and should be ignored, but the other changes are 
> still legit imho. Sorry also that I submitted the patches multiple times 
> in different arrangements. You should look at the *last* patches I 
> submitted (the ones in a range 1/5) and ignore the earlier ones.

You have at least 3 patches applied with your name in the git repos.


More information about the wayland-devel mailing list