[PATCH] weston: Don't ask for EGL depth buffer if not needed

Bill Spitzak spitzak at gmail.com
Thu Mar 22 02:59:32 PDT 2012

On 03/22/2012 01:43 AM, Pekka Paalanen wrote:

>> PS: I have not heard anything about my changes to wayland (there are 5
>> patches). One of them fixed a major bug for me. I believe my EAGAIN
>> changes are a mistake and should be ignored, but the other changes are
>> still legit imho. Sorry also that I submitted the patches multiple times
>> in different arrangements. You should look at the *last* patches I
>> submitted (the ones in a range 1/5) and ignore the earlier ones.
> You have at least 3 patches applied with your name in the git repos.

The one I am asking about is this, which fixed a real bug for me that 
caused the terminal to crash after about 12 keystrokes. It seems some 
minor changes I sent are getting pushed and commented on, while this 
major one is ignored:

connection.c sent a 4096 byte block of garbage if it wanted to send an
fd and there happened to be zero data to send as well.
  src/connection.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/connection.c b/src/connection.c
index fa01545..1f707ed 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -124,6 +124,10 @@ wl_buffer_get_iov(struct wl_buffer *b, struct iovec 
*iov, int *count)
  	int head, tail;

+	if (b->head == b->tail) {
+		*count = 0;
+		return;
+	}
  	head = MASK(b->head);
  	tail = MASK(b->tail);
  	if (tail < head) {

More information about the wayland-devel mailing list