weston freezes up my system when run it in a separate VT with a normal config file

[Daniel Stone]

Hi,

On 14 February 2013 17:24, Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Wed, Feb 13, 2013 at 08:50:39PM +0000, Rune Kjær Svendsen wrote:
> > Through trial-and-error editing the config file, I've found that this is
> > caused by the "keymap_layout=en" line in weston.ini. No freeze when this
> is
> > commented out.
> >
> > Because of this line weston tries to read /usr/share/X11/xkb/symbols/en
> > which doesn't exist, and it freezes, or at least makes me unable to
> switch
> > to a different VT or do anything besides reboot with Alt+SysRq+REISUB.
> If I
> > change the line to "keymap_layout=dk" there is no freeze
> > (/usr/share/X11/xkb/symbols/dk exists).
>
> Ah, I see... we have a rogue exit(1)s in the keyboard init path.  All
> of these cases should return an error instead of exiting, which will
> leave your system locked up (in KD_GRAPHICS mode with keyboard turned
> off).  That would be a good thing to audit and clean up.
>

Indeed; I just copied the prevailing style - which was to exit(1) - as
there are quite a few of them around, and some of the keyboard init is
(was?) done in void-returning functions.  Talking to Scott on IRC, another
good thing which came up would be to retry xkb_keymap_new_from_names with
an xkb_names struct with all-NULL members (currently we don't support a
NULL names parameter, which we should) to fall back to the default keymap,
which should hopefully work.

Oh, and while we're here, it would be kind of neat if all this led to
popping up a dialog box at Weston start saying 'BTW, your keyboard might be
all kinds of weird because I couldn't load the keymap'.  And a whole load
of other errors fed somewhere more useful than whichever VT we started
Weston on.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130214/cedbaf58/attachment-0001.html>