[PATCH 0/5] Input method support cleanup

Pekka Vuorela pvuorela at iki.fi
Thu Jan 31 14:26:22 PST 2013

On 31.01.2013 22:18, Jan Arne Petersen wrote:
> On 31.01.2013 16:38, Yichao Yu wrote:
>> On Thu, Jan 31, 2013 at 9:52 AM, Jan Arne Petersen
>> <jpetersen at openismus.com> wrote:
>>> From: Jan Arne Petersen <jpetersen at openismus.com>
>>> Another series of input method support patches. Mostly some
>>> cleanups in the protocol:
>>> * Remove some unused requests events (set_preedit etc)
>>> * Add a commit request to allow to batch different state
>>>    changes on application side together. That needs some more
>>>    documentation (also how it works in the other direction on
>>>    preedit_string and commit_string events).
>> Does it mean asking the input method to commit what it have now?
> That request is used the other way around telling the input method that
> it should handle the state (surrounding text, preferred language,
> content purposes/hints) sent by the application at one atomic point.
> Similar to wl_surface::commit.

Calling it commit is consistent with wl_surface, but here the word is 
quite overloaded. Perhaps commit_state, commit_updates, or something 
could be easier to understand in this context?

More information about the wayland-devel mailing list