[PATCH 0/5] Input method support cleanup

[Jan Arne Petersen]

On 31.01.2013 23:26, Pekka Vuorela wrote:
> On 31.01.2013 22:18, Jan Arne Petersen wrote:
>> On 31.01.2013 16:38, Yichao Yu wrote:
>>> On Thu, Jan 31, 2013 at 9:52 AM, Jan Arne Petersen
>>> <jpetersen at openismus.com> wrote:
>>>> From: Jan Arne Petersen <jpetersen at openismus.com>
>>>>
>>>> Another series of input method support patches. Mostly some
>>>> cleanups in the protocol:
>>>>
>>>> * Remove some unused requests events (set_preedit etc)
>>>>
>>>> * Add a commit request to allow to batch different state
>>>>    changes on application side together. That needs some more
>>>>    documentation (also how it works in the other direction on
>>>>    preedit_string and commit_string events).
>>>>
>>>
>>> Does it mean asking the input method to commit what it have now?
>>
>> That request is used the other way around telling the input method that
>> it should handle the state (surrounding text, preferred language,
>> content purposes/hints) sent by the application at one atomic point.
>> Similar to wl_surface::commit.
> 
> Calling it commit is consistent with wl_surface, but here the word is
> quite overloaded. Perhaps commit_state, commit_updates, or something
> could be easier to understand in this context?

I agree (I would go with commit_state), a better name than text_model
for the client side interface would be also nice (best idea we currently
have is text_editor).

-- 
Jan Arne Petersen
Openismus GmbH
http://www.openismus.com