[fbdev_backend]: support of DIRECTCOLOR Frame buffer

[Marc Chalain]

> You should execute the ioctl in fbdev_set_screen_info.
fbdev_set_screen_info is used only when the fb device is reenabled. The
colors map has to be initialized at the beginning in all cases.
If we use this function we will call it in all cases and it's not required.


>I don't see the codepath which results in cmap.transp being not set in the
test for it.
Yes... I forgot => new patch


>You don't initialize cmap.red so the test for it gives an undefined result.
Yes... error => new patch


>Don't define macros in the middle of code with a literal that's only used
once.
In fact that comes from the cmap.transp which are not always initialized.
In some cases transparency is useless. But I will repair => new patch

New patch


2013/6/7 John Kåre Alsaker <john.kare.alsaker at gmail.com>

> You should execute the ioctl in fbdev_set_screen_info.
>
> I don't see the codepath which results in cmap.transp being not set in the
> test for it.
>
> You don't initialize cmap.red so the test for it gives an undefined result.
>
> Don't define macros in the middle of code with a literal that's only used
> once.
>
> On Fri, Jun 7, 2013 at 12:18 PM, Marc Chalain <marc.chalain at gmail.com>wrote:
>
>> this patch allow to use direct color and set the colors map with default
>> value.
>>
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130607/53cc0a4a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: weston-fbdev-directcolor.patch
Type: application/octet-stream
Size: 2651 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130607/53cc0a4a/attachment.obj>