[fbdev_backend]: support of DIRECTCOLOR Frame buffer

[Pekka Paalanen]

On Fri, 7 Jun 2013 16:03:18 +0200
Marc Chalain <marc.chalain at gmail.com> wrote:

> > You should execute the ioctl in fbdev_set_screen_info.
> fbdev_set_screen_info is used only when the fb device is reenabled. The
> colors map has to be initialized at the beginning in all cases.
> If we use this function we will call it in all cases and it's not required.
> 
> 
> >I don't see the codepath which results in cmap.transp being not set in the
> test for it.
> Yes... I forgot => new patch
> 
> 
> >You don't initialize cmap.red so the test for it gives an undefined result.
> Yes... error => new patch
> 
> 
> >Don't define macros in the middle of code with a literal that's only used
> once.
> In fact that comes from the cmap.transp which are not always initialized.
> In some cases transparency is useless. But I will repair => new patch
> 
> New patch

Also, please use git-format-patch, and send the patches inline, not as
attachments. Furthermore, using git-send-email would guarantee, that the
patches do not get mangled by your email client.


Thanks,
pq