Helping in reviewing

[Thiago Macieira]

On terça-feira, 26 de março de 2013 12.50.46, Nick Kisialiou wrote:
> I'm not a Wayland developer but I suspect it wouldn't be wise to lump
> Wayland (protocol) and Weston (compositor) together on this issue.
> 
> Wayland:
> I'm not sure why it is a problem that Wayland patches take time to be
> merged. Isn't it the whole point of any protocol to be as stable as
> possible? If the protocol is constantly in some fluid experimental state
> then toolkit developers have no incentive to port their code. Outside of
> that, anyone who wants to do their experiments can easily do so in their
> local sandbox -- the code is open source after all.
> 
> Weston:
> IMHO, Weston patches don't need to go through the same rigorous review
> process.

I don't see a difference in this issue. I'm asking that people step up and 
review. That does not mean that we should start accepting sloppy reviews.

You're right, though, that Wayland changes require more attention and a more 
thorough analysis. That's part of the review process. And yes, it will require 
people with more experience to do those reviews. The catch is that we'll never 
get those people *unless* they start reviewing now.

So whenever you see a change that you think you can provide input on, do so. 
If you don't feel like saying it's completely fine, say so too. The initial 
review you provide on simpler things (coding style, thread-safety, etc.) is 
already helping.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130326/0dad2114/attachment.pgp>