[PATCH weston] clients/window: Don't remove the touch listener on a frame event

Neil Roberts neil at linux.intel.com
Wed Apr 23 10:02:47 PDT 2014


It looks like the handler for frame events from the wl_touch interface for
widgets may have been erroneously copied from the cancel handler so that it
removes all handlers as they are processed. I don't think this makes much sense
for the frame event. This was stopping the panel icons from being pushable with
touch events when using libinput since commit 1679f232e541489e. All that commit
does it make it start sending the frame events.
---
 clients/window.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/clients/window.c b/clients/window.c
index e770a04..e2f7010 100644
--- a/clients/window.c
+++ b/clients/window.c
@@ -3065,9 +3065,6 @@ touch_handle_frame(void *data, struct wl_touch *wl_touch)
 		if (tp->widget->touch_frame_handler)
 			(*tp->widget->touch_frame_handler)(tp->widget, input, 
 							   tp->widget->user_data);
-
-		wl_list_remove(&tp->link);
-		free(tp);
 	}
 }
 
-- 
1.9.0



More information about the wayland-devel mailing list