[PATCH weston] clients/window: Don't remove the touch listener on a frame event

[Kristian Høgsberg]

On Wed, Apr 23, 2014 at 06:02:47PM +0100, Neil Roberts wrote:
> It looks like the handler for frame events from the wl_touch interface for
> widgets may have been erroneously copied from the cancel handler so that it
> removes all handlers as they are processed. I don't think this makes much sense
> for the frame event. This was stopping the panel icons from being pushable with
> touch events when using libinput since commit 1679f232e541489e. All that commit
> does it make it start sending the frame events.

Yeah, that doesn't look right, patch applied.

Kristian

> ---
>  clients/window.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/clients/window.c b/clients/window.c
> index e770a04..e2f7010 100644
> --- a/clients/window.c
> +++ b/clients/window.c
> @@ -3065,9 +3065,6 @@ touch_handle_frame(void *data, struct wl_touch *wl_touch)
>  		if (tp->widget->touch_frame_handler)
>  			(*tp->widget->touch_frame_handler)(tp->widget, input, 
>  							   tp->widget->user_data);
> -
> -		wl_list_remove(&tp->link);
> -		free(tp);
>  	}
>  }
>  
> -- 
> 1.9.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel