[PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

[Pekka Paalanen]

On Wed, 27 Aug 2014 13:43:13 +0200
Sjoerd Simons <sjoerd.simons at collabora.co.uk> wrote:

> On Sun, 2014-08-03 at 10:39 +0300, Pekka Paalanen wrote:

> > As for wl_surface re-use after destroying a role, I have found that
> > resetting a role to allow re-use is much easier and cleaner than
> > not to, in Weston code. That's why I've been silently advocating to
> > allow re-use, but at the same I don't really expect clients to use
> > that. Yes, conflicting... so I suppose I don't have a real strong
> > preference there. Removing a role loses all role-specific
> > information, so whether the wl_surface get re-used or re-created
> > does not make any difference.
> 
> So with your blogpost you've nicely managed to convince me that we
> should keep the destroy request regardless of the semantics of it..
> 
> However, whether or not re-use is allowed should probably be made quite
> explicit and especially in the case of weston enforced (if not). I'm
> generally quite wary about having e.g. Weston be more permissive then
> other compositors (e.g. mutter) as that is likely to just lead to
> incompatibilities. If you continue that line of reasoning, it's probably
> best to not allow it simply such that the odd clients that do use re-use
> don't hit barely tested codepaths on compositors.

Yeah, we've had that discussion:
http://lists.freedesktop.org/archives/wayland-devel/2014-August/016735.html
http://lists.freedesktop.org/archives/wayland-devel/2014-August/016810.html
http://lists.freedesktop.org/archives/wayland-devel/2014-August/016811.html

Since I'm not really comfortable adding these in the middle of the
alpha phase, those patches will wait until 1.7 development begins.

But the principles have been agreed, no role-changing will be allowed,
and I think xdg-shell will define that behaviour for itself. Just
extending the behaviour to all roles is postponed to 1.7.


Thanks,
pq