[PATCH 2/2] ivi-shell: Say something when configuration is missing

Tanibata, Nobuhiko (ADITJ/SWG) ntanibata at jp.adit-jv.com
Mon Dec 8 16:29:15 PST 2014


How about adding more info like following to clearly say which shell output this log?
weston_log("ivi-shell: No ivi-module set in weston.conf\n");

BR,
Nobuhiko Tanibata

> -----Original Message-----
> From: wayland-devel
> [mailto:wayland-devel-bounces at lists.freedesktop.org] On Behalf Of
> Ond?ej Majerech
> Sent: Saturday, December 06, 2014 9:39 AM
> To: wayland-devel at lists.freedesktop.org
> Cc: Ondřej Majerech
> Subject: [PATCH 2/2] ivi-shell: Say something when configuration is
> missing
> 
> When ivi-module is not set in weston.conf, we probably want to tell the
> user about their error instead of just dying.
> 
> Signed-off-by: Ondřej Majerech <majerech.o at gmail.com>
> ---
>  ivi-shell/ivi-shell.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index
> a14010e..02fbafb 100644
> --- a/ivi-shell/ivi-shell.c
> +++ b/ivi-shell/ivi-shell.c
> @@ -385,6 +385,7 @@ ivi_shell_setting_create(struct ivi_shell_setting
> *dest,
>  	if (weston_config_section_get_string(
>  		section, "ivi-module", &dest->ivi_module, NULL) != 0)
>  	{
> +		weston_log("No ivi-module set in weston.conf\n");
>  		result = -1;
>  	}
> 
> --
> 1.9.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list