[PATCH v2 2/2] ivi-shell: Say something when configuration is missing
ppaalanen at gmail.com
Mon Dec 15 06:24:46 PST 2014
On Sat, 6 Dec 2014 02:49:18 +0100
Ondřej Majerech <majerech.o at gmail.com> wrote:
> When ivi-module is not set in weston.conf, we probably want to tell the
> user about their error instead of just dying.
> Signed-off-by: Ondřej Majerech <majerech.o at gmail.com>
> ivi-shell/ivi-shell.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c
> index a14010e..02fbafb 100644
> --- a/ivi-shell/ivi-shell.c
> +++ b/ivi-shell/ivi-shell.c
> @@ -385,6 +385,7 @@ ivi_shell_setting_create(struct ivi_shell_setting *dest,
> if (weston_config_section_get_string(
> section, "ivi-module", &dest->ivi_module, NULL) != 0)
> + weston_log("No ivi-module set in weston.conf\n");
> result = -1;
this seems to be a re-send of v1, without Tanibata's suggested
changes. I added them.
The file is weston.ini, not weston.conf, but I still changed it to talk
just about "config", to not hardcode the file name here.
I also modified the patch to fix the surrounding coding style here.
More information about the wayland-devel