[PATCH weston v1 11/17] add get_geometry & geometry request/event

[Marek Chalupa]

On 9 December 2014 at 21:39, Derek Foreman <derekf at osg.samsung.com> wrote:

> On 05/12/14 07:36 AM, Marek Chalupa wrote:
> > ---
> >  protocol/wayland-test.xml         | 11 +++++++++++
> >  tests/weston-test-client-helper.c | 18 ++++++++++++++++++
> >  tests/weston-test-client-helper.h |  6 ++++++
> >  tests/weston-test.c               | 23 +++++++++++++++++++++++
> >  4 files changed, 58 insertions(+)
> >
> > diff --git a/protocol/wayland-test.xml b/protocol/wayland-test.xml
> > index 18b6625..b4a6bc7 100644
> > --- a/protocol/wayland-test.xml
> > +++ b/protocol/wayland-test.xml
> > @@ -3,6 +3,7 @@
>
> I think we need to bump the interface version number when adding new stuff?
>
>
In previous commits to this protocol this was not true (e. g.
40c0c3f91eeb747b86df) - probably because nobody cares about it since its
testing..
Anyway, strictly speaking, yes, we should.


> > +static void
> > +get_geometry(struct wl_client *client, struct wl_resource *resource,
> > +          struct wl_resource *surface_resource)
> > +{
> > +     struct weston_view *view;
> > +     struct weston_surface *surface =
> > +             wl_resource_get_user_data (surface_resource);
>
> I don't think we put a space there...
>

Ooops.


Thanks,
Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20141210/b57321e4/attachment-0001.html>