[PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

[Pekka Paalanen]

On Wed, 10 Dec 2014 19:19:50 -0800
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Mon, Nov 24, 2014 at 01:01:29PM +0200, Pekka Paalanen wrote:
> > could we use a wl_shm-based wl_buffer instead of a file, please?
> > 
> > That way we can simply relay the pixels as is to the test client,
> > which can then compare without compressing and decompressing from
> > PNG first.
> > 
> > For an example how to do this, see Weston's screenshooter protocol
> > and implementation.
> > 
> > I think you also want to specify in the record_screenshot request:
> > - which output to capture (in case there are multiple)
> > - the rectangular sub-region that must be contained in the output
> >   (which you already do with the clip coords in a later patch, so
> > that should be squashed here)
> 
> Actually, if we're not storing the screenshot to a file on the server
> side, I wonder if we even need to communicate the sub-region coords to
> the server?  We can just let it pass the full image to the client and
> take care of clipping and whatnot all client-side.
> 
> It'd probably be more bandwidth efficient to just pass the bit of
> image we're going to test, but I don't think we care about that much
> here.  By doing it all client-side it'll keep the protocol and the
> server-side implementation more minimal.

True that. The only benefit would be copying less data when shooting,
but since this is testing, performance doesn't matter until someone
complains the tests take too long. :-)


Thanks,
pq