[PATCH libinput v3 07/17] touchpad: Only enable clickfingers on Apple touchpads

[Hans de Goede]

Hi,

On 05/22/2014 07:11 AM, Peter Hutterer wrote:
> On Tue, May 20, 2014 at 04:34:55PM +0200, Hans de Goede wrote:
>> From: Peter Hutterer <peter.hutterer at who-t.net>
>>
>> Apple touchpads don't have visible markings for the software button areas
>> that almost all other vendors use. OS X provides clickfinger behaviour
>> instead, where a click with two fingers on the touchpad generate a right
>> button click. Use that same behaviour in libinput.
>>
>> For all other touchpads, use the software button areas introduced in a
>> follow-up commit.
> 
> this one breaks the test, can you squash this diff in please?
> that's just to get the tests to succeed, you can drop it again in the 
> "touchpad: Add clickpad-style software buttons" commit
> 
> diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c
> index ef514f7..c155e37 100644
> --- a/src/evdev-mt-touchpad-buttons.c
> +++ b/src/evdev-mt-touchpad-buttons.c
> @@ -149,6 +149,8 @@ tp_post_button_events(struct tp_dispatch *tp, uint32_t time)
>                 rc = tp_post_physical_buttons(tp, time);
>         else if (tp->buttons.use_clickfinger)
>                 rc = tp_post_clickfinger_buttons(tp, time);
> +       else if (tp->nfingers_down >= 1)
> +               rc = tp_post_physical_buttons(tp, time);
>  
>         return rc;
>  }
> 


Instead of adding this diff I've swuashed this patch into
"touchpad: Add clickpad-style software buttons", which is where it really
belongs in the first place. With these 2 squashed together we also no
longer have an intermediate commit where the test suit fails.

Regards,

Hans