[PATCH wayland-web 1/7] Put a box around all code samples

[Pekka Paalanen]

On Fri, 23 May 2014 18:57:38 -0700
Bill Spitzak <spitzak at gmail.com> wrote:

> Not sure what happened here. I tested this and it came out with a
> header email, with all the patches as replies to it. But when I
> did it for real the header disappared. Header message:
> 
> This is v4 of this patch. It has been split into several commits,
> the diffs reduced by avoiding refilling paragraphs, and the Ubuntu
> specific instructions moved to their own document, and other
> changes based on comments from previous version.

Hi,

this is starting to look good. Here are some comments, that I think
I can fix when applying or in follow-up patches:

- add some home page links to project that people might need to
  build

- explain that linunwind only helps with weston crash reports and
  is safe to skip, if not intending to report bugs

- move the weston --disable-setuid-install away from the example
  line, and explain it in text; users will need weston-launch
  setuid root. Use sudo.

- $ sudo usermod -a -G $WLD/bin/weston-launch $USER
  is wrong, 'weston-launch' is a group name, not a file.

- No idea why you needed the CPPFLAGS for libepoxy, I certainly
  didn't need it and it should not be needed. Not to mention that
  variables set for configure should be arguments, not environment.
  If there is a problem, it needs to be fixed libepoxy upstream,
  since we are building it from git anyway.

- I'm not sure if <a href="/"> works locally, maybe just use the
  main page file name, so the links can be tested without
  publishing.

- Drop the note of removing LLVM by removing r300. You need LLVM
  also for llvmpipe at least, otherwise you get softpipe.

- (check libevdev)

- --with-xkb-config-root should not be needed, xkeyboard-config
  instead is.

- Drop the note about pam.

- The note added in patch 7 is wrong.

I think I won't touch the ubuntu12.04 page, so the
--disable-setuid-install, CPPFLAGS, etc. oddities can stay there if
you want.

I did not yet apply the patches and look at the result in a
browser, that will be for later.

Looks like I would at least go through and apply patches 1-4 early
next week with some fixes and the rest of the patches as time
permits. If you can do fixes based on these comments yourself and
re-post the series before Monday, that would help my work. Also,
check that after the complete series, every touched .html file
passes the check at
http://validator.w3.org/#validate_by_upload

Other comments, anyone?


Thanks,
pq