[PATCH wayland-web 1/7] Put a box around all code samples

[Bill Spitzak]

On 05/24/2014 12:45 AM, Pekka Paalanen wrote:
> On Fri, 23 May 2014 18:57:38 -0700
> Bill Spitzak <spitzak at gmail.com> wrote:
>
>> Not sure what happened here. I tested this and it came out with a
>> header email, with all the patches as replies to it. But when I
>> did it for real the header disappared. Header message:
>>
>> This is v4 of this patch. It has been split into several commits,
>> the diffs reduced by avoiding refilling paragraphs, and the Ubuntu
>> specific instructions moved to their own document, and other
>> changes based on comments from previous version.
>
> Hi,
>
> this is starting to look good. Here are some comments, that I think
> I can fix when applying or in follow-up patches:
>
> - add some home page links to project that people might need to
>    build

Good idea but actually these tend not to be in the README or any other 
file. I can certainly do some guesses from google search for the 
homepage. If you know any you may want to add them, but I will try to 
put my guesses in.

> - explain that linunwind only helps with weston crash reports and
>    is safe to skip, if not intending to report bugs

ok. Actually I thought that was obvious but more info can't hurt.

> - move the weston --disable-setuid-install away from the example
>    line, and explain it in text; users will need weston-launch
>    setuid root. Use sudo.

ok.

> - $ sudo usermod -a -G $WLD/bin/weston-launch $USER
>    is wrong, 'weston-launch' is a group name, not a file.

Thanks, that was a mistake.

> - No idea why you needed the CPPFLAGS for libepoxy, I certainly
>    didn't need it and it should not be needed. Not to mention that
>    variables set for configure should be arguments, not environment.
>    If there is a problem, it needs to be fixed libepoxy upstream,
>    since we are building it from git anyway.

Can't reproduce it on this machine, but I will try the other one 
Tuesday. I forget whether configure or make is what failed. I agree it 
is probably a minor bug in libepoxy.

> - I'm not sure if <a href="/"> works locally, maybe just use the
>    main page file name, so the links can be tested without
>    publishing.

That was there before, but I will change it to index.html.

> - Drop the note of removing LLVM by removing r300. You need LLVM
>    also for llvmpipe at least, otherwise you get softpipe.

That's what I thought. Without r300 it will silently configure without 
llvm but that is not what the user wants.

> - (check libevdev)
>
> - --with-xkb-config-root should not be needed, xkeyboard-config
>    instead is.

What is xkeyboard-config, a program I should run?

I'm also wondering if this is redundant with the instructions to link 
various kbd stuff into the prefix directory (in the xserver directions) 
or if maybe none of it is needed. As far as I can tell removing all of 
this does not cause anything to fail, but since I am running under X11 I 
suspect I am not hitting the necessary code.

> - Drop the note about pam.

ok

> - The note added in patch 7 is wrong.

I may need your help to fix this. All I know is that most of weston 
works without DRI2 in the x server and was trying to correct that.

> I think I won't touch the ubuntu12.04 page, so the
> --disable-setuid-install, CPPFLAGS, etc. oddities can stay there if
> you want.

Ok. Yes I think these things should stay.