[PATCH weston v3] input: don't send to clients key events eaten by bindings

[Pekka Paalanen]

On Tue, 11 Nov 2014 22:48:04 +0200
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> 2014-11-11 22:39 GMT+02:00 Bill Spitzak <spitzak at gmail.com>:
> > Better example:
> >
> > - Make an xterm have focus.
> >
> > - Make a new wayland terminal and give it focus.
> >
> > - In the Wayland terminal, press Ctrl, then D. The wayland terminal exits
> > due to the shell getting EOF and quitting. The xterm gets focus.
> >
> > - Release Ctrl but continue holding down 'd'. The 'd' starts to repeat in
> > the xterm.

I don't get this behaviour. The xterm gets Ctrl+d, interprets it as
EOF, and causes it eventually exit.

> >
> > The bug has nothing to do with whether a shortcut is a "server" shortcut or
> > not, and can be easily demonstrated with a "client shortcut".
> 
> Very well, so xwayland seems to have bug, since this doesn't happen
> with two weston-terminals. However, this has little to do with this
> patch, but rather with xwayland apparently ignoring the modifiers
> event it gets on focus-in.

Furthermore, lets do a test completely without Wayland at all, in X.

I am in a normal X session, nothing Wayland. I open an xterm. In that
xterm:

1. press down Ctrl
2. press down 'k'

Nothing happens.

3. release Ctrl

'k' starts to repeat in xterm!

So, it looks like X already has the behaviour you say is incorrect.

Xwayland is not meant to change the behaviour of X programs if
possible, and in this particular case Xwayland manages to reproduce the
exact same behaviour as native X.

If I do the same test with terminals and Ctrl+d in X, it will exit all
terminals one by one where the focus shifts to.


Thanks,
pq