[PATCH libinput] Install libinput-version.h

Peter Hutterer peter.hutterer at who-t.net
Tue Apr 28 14:53:50 PDT 2015


On Tue, Apr 28, 2015 at 08:27:03PM +0300, Jari Vetoniemi wrote:
> I was looking for this to avoid querying pkg-config in build system.
> Would be happy to see it included.
 
> 2015-04-28 19:19 GMT+03:00 Derek Foreman <derekf at osg.samsung.com>:
> > Just occurred to me, this should probably also add
> > #include <libinput-version.h>
> > to libinput.h?
> >
> > Or is there a reason we're not distributing this file?  It doesn't seem
> > to be used internally for any reason, so if it's not to be distributed,
> > should it just go away?

huh, funny. I didn't realize it was there. I'll make use of that in the
libinput-list-devices tool to make debugging easier but otherwise I don't
think we should install it. pkgconfig is what provides all the other
build options anyway.

Jari: why can't you use pkg-config?

Cheers,
   Peter

> >
> > On 28/04/15 11:07 AM, Derek Foreman wrote:
> >> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> >> ---
> >>  src/Makefile.am | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/src/Makefile.am b/src/Makefile.am
> >> index 90bdc9a..1f525ce 100644
> >> --- a/src/Makefile.am
> >> +++ b/src/Makefile.am
> >> @@ -3,7 +3,8 @@ noinst_LTLIBRARIES = libinput-util.la \
> >>                    libfilter.la
> >>
> >>  include_HEADERS =                    \
> >> -     libinput.h
> >> +     libinput.h                      \
> >> +     libinput-version.h
> >>
> >>  libinput_la_SOURCES =                        \
> >>       libinput.c                      \
> >>


More information about the wayland-devel mailing list