[PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

Derek Foreman derekf at osg.samsung.com
Wed Aug 5 10:15:50 PDT 2015


On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote:
> Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface
> belongs to, in order to trigger refreshing a list of surface in
> ivi_layout_layer.
> 
> Signed-off-by: Nobuhiko Tanibata <nobuhiko_tanibata at xddp.denso.co.jp>
> ---
>  ivi-shell/ivi-layout.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 2974bb7..bb175b0 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -2565,6 +2565,7 @@ ivi_layout_layer_remove_surface(struct ivi_layout_layer *ivilayer,
>  	}
>  
>  	remsurf->event_mask |= IVI_NOTIFICATION_REMOVE;
> +        ivilayer->event_mask |= IVI_NOTIFICATION_REMOVE;

This should be a tab, not 8 spaces...

Sorry I don't know enough to really review the code - to me it looks
like this just ends up removing all the surfaces from that layer in
commit_layer_list().

>  }
>  
>  static int32_t
> 



More information about the wayland-devel mailing list