[PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

[Nobuhiko Tanibata]

2015-08-06 02:15 に Derek Foreman さんは書きました:
> On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote:
>> Set a mask value to event_mask of ivi_layout_layer, a removed 
>> ivi_surface
>> belongs to, in order to trigger refreshing a list of surface in
>> ivi_layout_layer.
>> 
>> Signed-off-by: Nobuhiko Tanibata <nobuhiko_tanibata at xddp.denso.co.jp>
>> ---
>>  ivi-shell/ivi-layout.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
>> index 2974bb7..bb175b0 100644
>> --- a/ivi-shell/ivi-layout.c
>> +++ b/ivi-shell/ivi-layout.c
>> @@ -2565,6 +2565,7 @@ ivi_layout_layer_remove_surface(struct 
>> ivi_layout_layer *ivilayer,
>>  	}
>> 
>>  	remsurf->event_mask |= IVI_NOTIFICATION_REMOVE;
>> +        ivilayer->event_mask |= IVI_NOTIFICATION_REMOVE;
> 
> This should be a tab, not 8 spaces...
> 
> Sorry I don't know enough to really review the code - to me it looks
> like this just ends up removing all the surfaces from that layer in
> commit_layer_list().

Thank you for review!
I shall fix 8 spaces and add more clear commit message, and so on. I 
will improve this and send new one as V2.

BR,
Nobuhiko Tanibata

> 
>>  }
>> 
>>  static int32_t
>>